Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the e2e setup suite #2048

Merged
merged 7 commits into from
Jun 22, 2023
Merged

refactor: refactor the e2e setup suite #2048

merged 7 commits into from
Jun 22, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented May 16, 2023

Description

This pull request aims to refactor the e2e setup test suite, making it easier for us to utilize both QA tests and e2e tests.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 requested a review from a team as a code owner May 16, 2023 18:44
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2048 (f20a98d) into main (7f05ad4) will decrease coverage by 0.78%.
The diff coverage is 76.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2048      +/-   ##
==========================================
- Coverage   75.38%   74.61%   -0.78%     
==========================================
  Files         100      127      +27     
  Lines        8025     9805    +1780     
==========================================
+ Hits         6050     7316    +1266     
- Misses       1589     2004     +415     
- Partials      386      485      +99     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/keeper.go 64.28% <ø> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
x/leverage/keeper/borrows.go 78.57% <ø> (ø)
x/leverage/keeper/collateral.go 73.48% <ø> (+0.59%) ⬆️
x/leverage/keeper/errors.go 100.00% <ø> (ø)
... and 62 more

... and 25 files with indirect coverage changes

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will complicate merge into no-gb branch.

  1. Do we need to merge this PR now? If yes then could you handle the next merge main -> no-gb?

tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
tests/e2e/setup/chain.go Outdated Show resolved Hide resolved
tests/e2e/setup/chain.go Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jun 16, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Jun 16, 2023
@stale stale bot removed the S:Stale label Jun 21, 2023
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left one suggestion

tests/e2e/setup/chain.go Show resolved Hide resolved
@gsk967 gsk967 added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit 96cc7e9 Jun 22, 2023
25 checks passed
@gsk967 gsk967 deleted the sai/refactor_e2e_setup branch June 22, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants