-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor the e2e setup suite #2048
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
- Coverage 75.38% 74.61% -0.78%
==========================================
Files 100 127 +27
Lines 8025 9805 +1780
==========================================
+ Hits 6050 7316 +1266
- Misses 1589 2004 +415
- Partials 386 485 +99
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will complicate merge into no-gb
branch.
- Do we need to merge this PR now? If yes then could you handle the next merge
main -> no-gb
?
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left one suggestion
Description
This pull request aims to refactor the e2e setup test suite, making it easier for us to utilize both QA tests and e2e tests.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...