Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move cosmwasm into stable and x/incentive into experiemntal #2058

Merged
merged 4 commits into from
May 19, 2023

Conversation

robert-zaremba
Copy link
Member

We are finalizing the cosmwams release, so need to swap the experiemntal features.

@robert-zaremba robert-zaremba requested a review from a team as a code owner May 19, 2023 19:21
@toteki
Copy link
Member

toteki commented May 19, 2023

make sure to test the upgrade again before canon-2, to make sure we're not missing a line

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #2058 (fbda10c) into main (7f05ad4) will decrease coverage by 4.78%.
The diff coverage is 59.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
- Coverage   75.38%   70.61%   -4.78%     
==========================================
  Files         100      126      +26     
  Lines        8025     9585    +1560     
==========================================
+ Hits         6050     6768     +718     
- Misses       1589     2350     +761     
- Partials      386      467      +81     
Impacted Files Coverage Δ
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/keeper/incentive.go 0.00% <0.00%> (ø)
x/oracle/keeper/hooks.go 95.65% <ø> (ø)
x/ugov/keeper/msg_server.go 0.00% <0.00%> (ø)
x/ugov/keeper/query_server.go 0.00% <0.00%> (ø)
x/uibc/quota/keeper/genesis.go 0.00% <0.00%> (-100.00%) ⬇️
x/uibc/quota/keeper/grpc_query.go 0.00% <0.00%> (-76.93%) ⬇️
... and 47 more

... and 2 files with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pre Approving
Can you check the comments

app/app.go Outdated Show resolved Hide resolved
app/app.go Show resolved Hide resolved
app/experimental_appconfig.go Show resolved Hide resolved
Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
@robert-zaremba robert-zaremba added this pull request to the merge queue May 19, 2023
Merged via the queue into main with commit 7343e2d May 19, 2023
@robert-zaremba robert-zaremba deleted the robert/experimental branch May 19, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants