-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update numeric store getters to return bool if value is missing #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
commented
Jul 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #2169 +/- ##
==========================================
- Coverage 75.38% 70.30% -5.09%
==========================================
Files 100 148 +48
Lines 8025 11310 +3285
==========================================
+ Hits 6050 7951 +1901
- Misses 1589 2816 +1227
- Partials 386 543 +157
|
kosegor
reviewed
Jul 26, 2023
kosegor
approved these changes
Jul 26, 2023
toteki
reviewed
Jul 26, 2023
toteki
reviewed
Jul 26, 2023
toteki
reviewed
Jul 26, 2023
toteki
approved these changes
Jul 26, 2023
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Numeric getters (Big Int, Dec, int, int64...) returned zero value if the value was not present in the store, without letting know if the value is there. That can cause unexpected behavior when zero is a proper value, but we want to know if it was present in the store or not.
This PR adds
bool
return type to numeric getters and the time getter.