Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added upgrade handler for new token emission #2176

Merged
merged 8 commits into from
Aug 1, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Jul 31, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2176 (b9f5591) into main (7f05ad4) will decrease coverage by 6.56%.
Report is 162 commits behind head on main.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
- Coverage   75.38%   68.83%   -6.56%     
==========================================
  Files         100      153      +53     
  Lines        8025    11697    +3672     
==========================================
+ Hits         6050     8052    +2002     
- Misses       1589     3103    +1514     
- Partials      386      542     +156     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/store.go 70.67% <ø> (ø)
x/incentive/keeper/unbonding.go 80.45% <ø> (ø)
x/incentive/keeper/update.go 52.11% <ø> (ø)
x/incentive/keys.go 100.00% <ø> (ø)
x/incentive/msgs.go 77.41% <ø> (-0.81%) ⬇️
x/incentive/params.go 89.28% <ø> (-10.72%) ⬇️
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
... and 55 more

... and 58 files with indirect coverage changes

@gsk967 gsk967 changed the title chore(WIP): added upgrade handler for new token emission chore: added upgrade handler for new token emission Jul 31, 2023
@gsk967 gsk967 requested review from toteki and kosegor July 31, 2023 11:31
@gsk967 gsk967 marked this pull request as ready for review July 31, 2023 11:31
@gsk967 gsk967 requested a review from a team as a code owner July 31, 2023 11:31
@gsk967 gsk967 enabled auto-merge July 31, 2023 14:35
app/upgrades.go Outdated Show resolved Hide resolved
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added approval, but let me know on slack what our plans are for the testnet are

@gsk967 gsk967 added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit ef751bf Aug 1, 2023
25 checks passed
@gsk967 gsk967 deleted the sai/new_token_emission_migrations branch August 1, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants