feat: migrating cosmos-sdk from v0.47 to v0.50 #2567
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| receiverVal := k.StakingKeeper.Validator(ctx, winner.Validator) | ||
| receiverVal, err := k.StakingKeeper.Validator(ctx, winner.Validator) | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to get validator %s and error %w", winner.Validator.String(), err)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| k.distrKeeper.AllocateTokensToValidator(ctx, receiverVal, sdk.NewDecCoinsFromCoins(rewardCoins...)) | ||
| err = k.distrKeeper.AllocateTokensToValidator(ctx, receiverVal, sdk.NewDecCoinsFromCoins(rewardCoins...)) | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to allocate tokens to validator %w", err)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| for acc := range GetMaccPerms() { | ||
| modAccAddrs[authtypes.NewModuleAddress(acc).String()] = true | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, m := range app.mm.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...