chore: update the params for mainnet

[gsk967]

Description

closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• added appropriate labels to the PR
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

Summary by CodeRabbit

• New Features

  • Transitioned auction upgrade to a stable version, improving the upgrade process.
  • Adjusted auction parameters for enhanced functionality.

• Bug Fixes

  • Reverted bid duration from 4 hours to 14 days to improve auction dynamics.

• Chores

  • Removed irrelevant comments to streamline code clarity.

[coderabbitai]

Walkthrough

The recent updates enhance the Umee application's auction system by transitioning to a stable version of the upgrade. Key adjustments include an increase in auction fees and a significant change in the bid duration, reflecting a strategic focus on optimizing auction dynamics and reward distribution. These modifications aim to improve overall functionality and economic parameters, fostering a more robust user experience in the Umee ecosystem.

Changes

Files	Change Summary
app/upgrades.go	Renamed upgrade function to remove "RC1"; updated plan name to "v6.6"; adjusted auction fees: increased RewardsAuctionFee and decreased RewardsAuctionFeeFactor.
x/auction/genesis.go, x/auction/msgs.go	Reverted BidDuration from 4 hours to 14 days; removed a TODO comment in msgs.go, simplifying the code while keeping MinRewardsBid unchanged.

Poem

Hop along, the upgrades here,
With fees and bids now crystal clear.
From hours to days, we leap and bound,
In Umee's fields, new joys are found!
A stable path the rabbits tread,
For better auctions, onward we head! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (7f05ad4) to head (71158b7).
Report is 518 commits behind head on main.

Files	Patch %	Lines
app/upgrades.go	33.33%	2 Missing ⚠️
x/auction/genesis.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2580       +/-   ##
===========================================
- Coverage   75.38%   62.55%   -12.84%     
===========================================
  Files         100      275      +175     
  Lines        8025    16035     +8010     
===========================================
+ Hits         6050    10031     +3981     
- Misses       1589     5231     +3642     
- Partials      386      773      +387     

Files	Coverage Δ
x/auction/msgs.go	50.00% <ø> (ø)
x/auction/genesis.go	0.00% <0.00%> (ø)
app/upgrades.go	48.50% <33.33%> (ø)

... and 238 files with indirect coverage changes

[coderabbitai]

Actionable comments posted: 3

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d3c61d and 71158b7.

Files selected for processing (3)

• app/upgrades.go (1 hunks)
• x/auction/genesis.go (1 hunks)
• x/auction/msgs.go (1 hunks)

Files skipped from review due to trivial changes (1)

• x/auction/msgs.go

Additional context used

GitHub Check: codecov/patch

x/auction/genesis.go

[warning] 13-13: x/auction/genesis.go#L13
Added line #L13 was not covered by tests

app/upgrades.go

[warning] 70-70: app/upgrades.go#L70
Added line #L70 was not covered by tests

---

[warning] 77-77: app/upgrades.go#L77
Added line #L77 was not covered by tests

Additional comments not posted (5)

x/auction/genesis.go (1)

13-13: Verify the rationale behind the change in BidDuration.

The BidDuration parameter has been changed from 4 hours to 14 days. Ensure that this change aligns with the intended auction dynamics and reward distribution strategy.

Tools

GitHub Check: codecov/patch

[warning] 13-13: x/auction/genesis.go#L13
Added line #L13 was not covered by tests

app/upgrades.go (4)

62-62: Verify the rationale behind the renaming and plan name update.

The function registerUpgrade6_6RC1 has been renamed to registerUpgrade6_6, and the plan name has been updated from "v6.6-rc1" to "v6.6". Ensure that this change aligns with the intended upgrade path and versioning strategy.

---

62-62: LGTM!

The code changes are approved.

---

70-70: Verify the rationale behind the increase in RewardsAuctionFee.

The RewardsAuctionFee parameter has been increased from 0.01 to 0.02. Ensure that this change aligns with the intended economic model and user engagement strategy.

Tools

GitHub Check: codecov/patch

[warning] 70-70: app/upgrades.go#L70
Added line #L70 was not covered by tests

---

77-77: Verify the rationale behind the decrease in RewardsAuctionFeeFactor.

The RewardsAuctionFeeFactor parameter has been decreased from 10000 to 1000. Ensure that this change aligns with the intended economic model and user engagement strategy.

Tools

GitHub Check: codecov/patch

[warning] 77-77: app/upgrades.go#L77
Added line #L77 was not covered by tests

[hoffmabc]

LGTM