Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: liquidate command from-address #829

Merged
merged 3 commits into from
Apr 22, 2022
Merged

fix: liquidate command from-address #829

merged 3 commits into from
Apr 22, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Apr 22, 2022

Description

liquidate command was using borrower address as liquidator


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

@toteki
Copy link
Member Author

toteki commented Apr 22, 2022

Note: This is in the client so it's not state machine breaking. We can merge it into any release.

@toteki toteki marked this pull request as ready for review April 22, 2022 01:07
@toteki toteki requested review from a team as code owners April 22, 2022 01:07
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just need the test fixed 👍

@codecov-commenter
Copy link

Codecov Report

Merging #829 (4cd25a5) into main (4062f6e) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   50.93%   50.93%           
=======================================
  Files          64       64           
  Lines        9428     9428           
=======================================
  Hits         4802     4802           
  Misses       4383     4383           
  Partials      243      243           
Impacted Files Coverage Δ
x/leverage/types/tx.go 0.00% <0.00%> (ø)
x/leverage/simulation/operations.go 91.66% <100.00%> (ø)

@toteki toteki changed the title fix: liquidate command was using borrower address as liquidator fix: liquidate command from-address Apr 22, 2022
@adamewozniak adamewozniak merged commit 183987d into main Apr 22, 2022
@adamewozniak adamewozniak deleted the adam/licc branch April 22, 2022 14:43
mergify bot pushed a commit that referenced this pull request Apr 22, 2022
adamewozniak pushed a commit that referenced this pull request Apr 22, 2022
(cherry picked from commit 183987d)

Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants