Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinvent icu_pattern with support for multiple backends #4610

Merged
merged 46 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
05411b3
Remove everything from icu_pattern except for the parser
sffc Feb 14, 2024
5736213
Make the crate no_std
sffc Feb 14, 2024
7dd18db
Add num_pattern module with code recovered from #4579
sffc Feb 14, 2024
b9a45bf
Restore some more code
sffc Feb 14, 2024
752b9ec
Implement iterator for new data model
sffc Feb 14, 2024
519c3b3
Update docs
sffc Feb 14, 2024
d36d4b7
Start implementing new trait structure in icu_pattern
sffc Feb 16, 2024
705de6e
Checkpoint
sffc Feb 17, 2024
c8bc229
Checkpoint
sffc Feb 17, 2024
3d0a37e
Move impls
sffc Feb 17, 2024
a3787fc
Add another example
sffc Feb 17, 2024
8a14523
fmt docs
sffc Feb 17, 2024
025ea73
Make the trait be sealed
sffc Feb 20, 2024
0dedfb6
Docs
sffc Feb 20, 2024
c8c1f64
Add format to parts
sffc Feb 20, 2024
0b1d28b
Docs
sffc Feb 20, 2024
e482bda
Checkpoint
sffc Feb 20, 2024
74df864
New data model for patterns without placeholders
sffc Feb 20, 2024
00d870d
Moving last useful code out of num_pattern module
sffc Feb 20, 2024
62b509c
Moving things around into modules
sffc Feb 20, 2024
9d0263c
PatternToken -> ParsedPatternItem
sffc Feb 20, 2024
712fbc4
Enable more lints
sffc Feb 20, 2024
fa540d7
Clippy fix
sffc Feb 20, 2024
7d6bb6f
Clippy
sffc Feb 20, 2024
1458216
Docs and features
sffc Feb 21, 2024
6730f61
Docs
sffc Feb 21, 2024
56e735d
generate-readmes
sffc Feb 21, 2024
2445631
A little bit more in docs
sffc Feb 21, 2024
9054786
Fix sealed trait issue
sffc Feb 21, 2024
2868365
Internal docs and cleanup
sffc Feb 21, 2024
8be2b46
Update utils/pattern/src/single.rs
sffc Feb 27, 2024
07b313a
Update utils/pattern/src/single.rs
sffc Feb 27, 2024
a152c6b
Use empty enum convention for non-constructible type
sffc Feb 27, 2024
7e6ae57
Reject placeholder offset >= 0xD800
sffc Feb 27, 2024
287d460
Be more explicit about unreachable cases
sffc Feb 27, 2024
3d538e9
Add size_hint impl with debug assertions test in impl Writeable
sffc Feb 27, 2024
cac96f5
Update utils/pattern/src/single.rs
sffc Feb 27, 2024
7d9d977
Clippy
sffc Feb 27, 2024
8d8156e
offsets are in range
sffc Feb 27, 2024
8375087
len_utf8
sffc Feb 27, 2024
b42eaaa
ExactSizeIterator
sffc Feb 27, 2024
7b4c7f7
Call validate_store() more often with debug assertions enabled
sffc Feb 27, 2024
773351f
Merge remote-tracking branch 'upstream/main' into neopattern2
sffc Feb 27, 2024
7d5e0f2
fmt
sffc Feb 27, 2024
4de871f
Generalize size_hint assertion test
sffc Feb 27, 2024
43c6f73
Fix warning when building release mode
sffc Feb 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions utils/pattern/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ all-features = true
displaydoc = { version = "0.2.3", default-features = false }
writeable = { workspace = true }

[dev-dependencies]
iai = "0.1"

[[bench]]
name = "parser_iai"
harness = false
[features]
alloc = []
std = ["alloc"]
97 changes: 13 additions & 84 deletions utils/pattern/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading