Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more impls to Pattern #4658

Merged
merged 13 commits into from
Mar 7, 2024
Merged

Add more impls to Pattern #4658

merged 13 commits into from
Mar 7, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Mar 6, 2024

Depends on #4657
Depends on #4659
Depends on #4663

This adds Databake, Yokeable, and ZeroFrom. Serde will follow.

See #4610

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pattern code is mostly fine

utils/pattern/src/frontend/mod.rs Outdated Show resolved Hide resolved
Copy link

dpulls bot commented Mar 7, 2024

🎉 All dependencies have been resolved !

robertbastian
robertbastian previously approved these changes Mar 7, 2024
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog for databake please

Manishearth
Manishearth previously approved these changes Mar 7, 2024
@sffc
Copy link
Member Author

sffc commented Mar 7, 2024

changelog for databake please

#4663

Copy link

dpulls bot commented Mar 7, 2024

🎉 All dependencies have been resolved !

@sffc sffc removed the request for review from zbraniecki March 7, 2024 14:51
@sffc sffc merged commit 1734713 into unicode-org:main Mar 7, 2024
30 checks passed
@sffc sffc deleted the pattern_derives branch March 7, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants