Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear latestTypecheckedFile on update #5270

Merged
merged 2 commits into from
Aug 10, 2024
Merged

clear latestTypecheckedFile on update #5270

merged 2 commits into from
Aug 10, 2024

Conversation

aryairani
Copy link
Contributor

Overview

#3424 restated is:

You have a calls b calls c, with a and c in the scratch file but b is not in the scratch file. You modify c and run update.

a, b, c will be updated correctly in the branch, but when you run a it will use the stale one from the Cli state and not the updated one. So it will not reflect the changes you just made to c, which is mystifying.

Your scratch file looks right and view looks right, but run a will call old code until you load again or restart ucm.

This PR fixes the issue by clearing latestTypecheckedFile at the end of update.

Test coverage

Diff of transcript output before and after the fix: c4f8ffc

@aryairani aryairani merged commit d5d9d9d into trunk Aug 10, 2024
35 checks passed
@aryairani aryairani deleted the arya/fix-3424 branch August 10, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants