Numbers binary notation #5294
Merged
Numbers binary notation #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for the binary notation for Nat and Int types (e.g.,
0b101,-0b11). At first, I added a binary literal in the transcript that had invalid binary characters in the middle of the literal (e.g.,0b1210), and I got this error:But the same error is thrown with hexadecimal and octal notations. So I assumed that this is an expected behavior for now. Also, I added syntax highlighting for Vim. I found that Atom's config doesn't distinguish number notations. Did I miss something?
In addition, I have to add binary notation in documentation for Nat and Int in Unison Share, right?