Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding of a TimeSeries .drop() method #880

Closed
rokkian opened this issue Mar 29, 2022 · 3 comments · Fixed by #1040
Closed

Adding of a TimeSeries .drop() method #880

rokkian opened this issue Mar 29, 2022 · 3 comments · Fixed by #1040
Labels
improvement New feature or improvement

Comments

@rokkian
Copy link

rokkian commented Mar 29, 2022

Is your feature request related to a current problem? Please describe.
I haven't found in the TimeSeries documentation anything similar to a pd.DataFrame .drop() method and I think it would be compfy to have such.
Surely It ait't something critical, but in order to remove some componentes from multivariate TimeSeries, would be more comfy to my opinion.

Describe proposed solution
At the moment I worked around it using set() differences between the set of components of the TimeSeries and the compinent I want to remove:
ts[list(set(ts.columns) - set(['stop_time']))]

Describe potential alternatives
I hope not to be wasting your time if such operation is already implemented through slicing operations [ ]

@rokkian rokkian added the triage Issue waiting for triaging label Mar 29, 2022
@hrzn
Copy link
Contributor

hrzn commented Apr 14, 2022

This is a good idea - adding to our backlog. @rokkian let us know if you would be willing to work on adding such a method to the TimeSeries class.

@hrzn hrzn added improvement New feature or improvement and removed triage Issue waiting for triaging labels Apr 14, 2022
@rokkian
Copy link
Author

rokkian commented Apr 14, 2022

@hrzn more than happy to contribute!

@hrzn
Copy link
Contributor

hrzn commented Apr 14, 2022

Awesome! Then I'd redirect you to our contributing guidelines as a place to start. Then, for this issue, I think a good place to start would be to check how other TimeSeries methods are implemented, for instance some of the methods below this line. Once you feel ready about the approach, just go ahead and open a PR. Let me know if you need help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants