Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds drop_columns method to TimeSeries #1040

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

shaido987
Copy link
Contributor

Fixes #880.

Summary

Adds a function to drop one or multiple columns to the TimeSeries. I tried follow the format and style of the other TimeSeries methods and also added a test to the tests/test_timeseries_multivariate file (since it does not make sense to drop columns in a single column time series).

@shaido987 shaido987 changed the title Feature/drop columns Adds drop_columns method to TimeSeries Jun 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #1040 (d26fb0f) into master (945ded5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.01%     
==========================================
  Files          77       77              
  Lines        7870     7862       -8     
==========================================
- Hits         7187     7179       -8     
  Misses        683      683              
Impacted Files Coverage Δ
darts/timeseries.py 92.04% <100.00%> (-0.02%) ⬇️
darts/models/__init__.py 86.04% <0.00%> (-0.32%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.51% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.14% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.25% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945ded5...d26fb0f. Read the comment docs.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hrzn hrzn merged commit 8eb331a into unit8co:master Jun 27, 2022
@shaido987 shaido987 deleted the feature/drop-columns branch June 27, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding of a TimeSeries .drop() method
3 participants