Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/gradle #112

Merged
merged 7 commits into from
Jun 30, 2020
Merged

Feat/gradle #112

merged 7 commits into from
Jun 30, 2020

Conversation

Kostiiii
Copy link
Contributor

First step of introducing gradle to project.

Define tasks to build documentations, docker image, to run tests and some 'helpers' for installing requirements or project locally.

@Kostiiii Kostiiii requested review from hrzn and TheMP as code owners June 23, 2020 17:26
@Kostiiii Kostiiii requested a review from endrjuskr June 23, 2020 17:27
@Kostiiii
Copy link
Contributor Author

I will update readme with how we can use gradle etc, but will wait with that until changes to readme structure.

}
}

dockerRun {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works then probably clutter like run_docker.sh can be removed from repo (alsoe README should be updated)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts directory removed + readme updated.

- name: "6. Run linter"
run: |
flake8 --config=setup.cfg darts
./gradlew test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might still need the step to eg. attach the cache for pip, probably not a gradle thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry I went into berserk delete everything mode.

@@ -104,39 +56,10 @@ jobs:
with:
python-version: 3.6

- name: "3. Update pip and install pandoc"
- name: "3. Install pandoc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark - might still need to mount pip cache

build.gradle Outdated
commandLine "python", "-m", "pip", "install", "--upgrade", "pip"
}

void pipInstallSteps() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we pick some of those steps? some build tasks need main + release, some need main + dev so installing all of those is not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that form we couldn't but now it is splitted into 3 task and in other places tasks now depend only on needed requirements.

// Documentation build
void docSteps() {
exec {
commandLine "make", "--directory", "./docs", "copy-examples"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any gradle plugin for Makefile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick googling didn't revealed any trustworthy looking plugins and to be honest I feel like plugin for Makefile would be an overkill.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@guillaumeraille guillaumeraille mentioned this pull request Jun 24, 2020
@TheMP
Copy link
Contributor

TheMP commented Jun 29, 2020

I will update readme with how we can use gradle etc, but will wait with that until changes to readme structure.

@Kostiiii new README is out so feel free to take a shot at it :)

@Kostiiii
Copy link
Contributor Author

I will update readme with how we can use gradle etc, but will wait with that until changes to readme structure.

@Kostiiii new README is out so feel free to take a shot at it :)

@TheMP I think I extended README from develop branch already, did you see it? Do you want it to have some section I didn't include or to elaborate on something with more details?

@Kostiiii Kostiiii merged commit 3b35a13 into develop Jun 30, 2020
@Kostiiii Kostiiii deleted the feat/gradle branch June 30, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants