Fix/nan in resample #1350
Merged
Fix/nan in resample #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el, closed, loffset and base
…the docstring accordingly and added an example
Codecov ReportBase: 93.88% // Head: 93.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 78 78
Lines 8508 8508
=======================================
Hits 7988 7988
Misses 520 520
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hrzn
approved these changes
Nov 13, 2022
| to start the resampling and avoid nan at the first value of the resampled TimeSeries | ||
| (https://docs.xarray.dev/en/stable/generated/xarray.DataArray.resample.html) | ||
|
|
||
| Examples |
rephrasing of the docstring using hyperlink Co-authored-by: Julien Herzen <julien@unit8.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1237.
Summary
Added kwargs to
TimeSeries.resampleto be able to pass arguments to thexarray.resamplemethod and give the possibility to the user to shift the start of the resampling to avoid gettingnanat the beginning of the resampledTimeSeries.Other Information
Write an example in the docstring to cover the most likely usage, it might be too long...