Generation/pass frequency #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMP
reviewed
Jul 21, 2020
| self.assertAlmostEqual(linear_ts.values()[-1][0] - linear_ts.values()[-2][0], | ||
| (end_value - start_value) / (length - 1)) | ||
|
|
||
| for length in range(2, 50): |
There was a problem hiding this comment.
seems to be doing much more iterations now, how much slower is it?
There was a problem hiding this comment.
Also - do we need to go over all interegs from 2 to 50 or is it enough to pick up start, middle and end point?
There was a problem hiding this comment.
I feel like we don't have worry about it too much since this tests are really fast. But it is probably enough to test few options here so will change it to your proposition
There was a problem hiding this comment.
For the record github actions were around 30 seconds slower so in the end it was worth it to change it.
TheMP
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added freq passing to couple of timeseries generating function to allow creating smaller timeseries + update tests to check if it possible to create timeseries with those lengths.