Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(externals): apply production condition to package.exports #867

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 23, 2023

πŸ”— Linked issue

resolves #844

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Rewrite package.json with production condition in exports field before writing to be consistent with the condition of resoluton before. Tested against two linked packages.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. πŸ‘Œ

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #867 (97953c6) into main (a5586f8) will decrease coverage by 0.07%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   67.20%   67.14%   -0.07%     
==========================================
  Files          59       59              
  Lines        5797     5816      +19     
  Branches      617      624       +7     
==========================================
+ Hits         3896     3905       +9     
- Misses       1893     1903      +10     
  Partials        8        8              
Impacted Files Coverage Ξ”
src/rollup/plugins/externals.ts 93.56% <95.83%> (-1.07%) ⬇️
src/presets/edgio.ts 5.55% <0.00%> (-1.86%) ⬇️
src/rollup/config.ts 92.12% <0.00%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply production contraint to traced package.json files
2 participants