Skip to content

Commit

Permalink
[backend] pin pip to 24.0 (#1132)
Browse files Browse the repository at this point in the history 
pin pip to version 24.0. versions > 24.0
  fails to install celery.
Pin to 24.0 until we have time to
  upgrade celery and other things

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
  • Loading branch information
@NdibeRaymond
NdibeRaymond and Ndibe Raymond Olisaemeka committed Jul 17, 2024
1 parent 1f7a025 commit fc2d59e
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 10 deletions.
4 changes: 3 additions & 1 deletion zubhub_backend/compose/celery/prod/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ WORKDIR /celery
# copying neccessary files to work directory
COPY ./compose/celery/requirements.txt /celery/

RUN pip install --upgrade pip wheel \
RUN pip install --upgrade wheel \
# pip versions greater than 24.0 fails to install celery 4.4.0. pin pip until we are ready to upgrade celery
&& pip install pip==24.0 \
# Requirements are installed here to ensure they will be cached.
&& pip install -r /celery/requirements.txt

Expand Down
4 changes: 3 additions & 1 deletion zubhub_backend/compose/flower/prod/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ WORKDIR /flower
# copying neccessary files to work directory
COPY ./compose/flower/requirements.txt /flower/

RUN pip install --upgrade pip wheel \
RUN pip install --upgrade wheel \
# pip versions greater than 24.0 fails to install celery 4.4.0. pin pip until we are ready to upgrade celery
&& pip install pip==24.0 \
# Requirements are installed here to ensure they will be cached.
&& pip install -r /flower/requirements.txt

Expand Down
6 changes: 4 additions & 2 deletions zubhub_backend/compose/media/dev/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ WORKDIR /home
# copying neccessary files to work directory
COPY ./compose/media/requirements.txt /home/

RUN pip install --upgrade pip wheel \
RUN pip install --upgrade wheel \
# pip versions greater than 24.0 fails to install celery 4.4.0. pin pip until we are ready to upgrade celery
&& pip install pip==24.0 \
# Requirements are installed here to ensure they will be cached.
&& pip install -r /home/requirements.txt

Expand All @@ -40,4 +42,4 @@ COPY ./compose/docker_secrets_expand.sh /docker_secrets_expand.sh
RUN sed -i 's/\r$//g' /docker_secrets_expand.sh
RUN chmod +x /docker_secrets_expand.sh

ENTRYPOINT [ "/home/start" ]
ENTRYPOINT [ "/home/start" ]
6 changes: 4 additions & 2 deletions zubhub_backend/compose/media/prod/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ WORKDIR /home
# copying neccessary files to work directory
COPY ./compose/media/requirements.txt /home/

RUN pip install --upgrade pip wheel \
RUN pip install --upgrade wheel \
# pip versions greater than 24.0 fails to install celery 4.4.0. pin pip until we are ready to upgrade celery
&& pip install pip==24.0 \
# Requirements are installed here to ensure they will be cached.
&& pip install -r /home/requirements.txt

Expand All @@ -39,4 +41,4 @@ COPY ./compose/docker_secrets_expand.sh /docker_secrets_expand.sh
RUN sed -i 's/\r$//g' /docker_secrets_expand.sh
RUN chmod +x /docker_secrets_expand.sh

ENTRYPOINT [ "/home/start" ]
ENTRYPOINT [ "/home/start" ]
6 changes: 4 additions & 2 deletions zubhub_backend/compose/web/dev/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ WORKDIR /zubhub_backend
# copying neccessary files to work directory
COPY ./compose/web/requirements.txt /zubhub_backend/

RUN pip install --upgrade pip wheel \
RUN pip install --upgrade wheel \
# pip versions greater than 24.0 fails to install celery 4.4.0. pin pip until we are ready to upgrade celery
&& pip install pip==24.0 \
# Requirements are installed here to ensure they will be cached.
&& pip install -r /zubhub_backend/requirements.txt

Expand All @@ -41,4 +43,4 @@ COPY ./compose/docker_secrets_expand.sh /docker_secrets_expand.sh
RUN sed -i 's/\r$//g' /docker_secrets_expand.sh
RUN chmod +x /docker_secrets_expand.sh

ENTRYPOINT [ "/zubhub_backend/start" ]
ENTRYPOINT [ "/zubhub_backend/start" ]
6 changes: 4 additions & 2 deletions zubhub_backend/compose/web/prod/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ WORKDIR /zubhub_backend
# copying neccessary files to work directory
COPY ./compose/web/requirements.txt /zubhub_backend/

RUN pip install --upgrade pip wheel \
RUN pip install --upgrade wheel \
# pip versions greater than 24.0 fails to install celery 4.4.0. pin pip until we are ready to upgrade celery
&& pip install pip==24.0 \
# Requirements are installed here to ensure they will be cached.
&& pip install -r /zubhub_backend/requirements.txt

Expand All @@ -40,4 +42,4 @@ COPY ./compose/docker_secrets_expand.sh /docker_secrets_expand.sh
RUN sed -i 's/\r$//g' /docker_secrets_expand.sh
RUN chmod +x /docker_secrets_expand.sh

ENTRYPOINT [ "/zubhub_backend/start" ]
ENTRYPOINT [ "/zubhub_backend/start" ]

0 comments on commit fc2d59e

Please sign in to comment.