Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor github actions #1030

Open
5 of 6 tasks
NdibeRaymond opened this issue Dec 14, 2023 · 1 comment
Open
5 of 6 tasks

refactor github actions #1030

NdibeRaymond opened this issue Dec 14, 2023 · 1 comment
Assignees
@NdibeRaymond

Comments

@NdibeRaymond
Copy link
Collaborator

NdibeRaymond commented Dec 14, 2023 •
edited
Loading

as @yokwejuste pointed out in the recent auto-create-test-vm action PR, our github actions are a bit outdated and requires some refactoring. Though they still work, it makes sense to update them. Things that needs to be done in no particular order:

  • use matrix strategy for similar jobs to save time
  • update version of third-party actions
  • use composite actions
  • improve readability
  • add action to auto perform docker system prune on all desired vm before or after each deployment.
  • remove QEMU from github actions (since we are not doing multi-platform build)
@NdibeRaymond NdibeRaymond self-assigned this Dec 14, 2023
@yokwejuste
Copy link
Collaborator

Also, I was thinking of us having some few variables there and making the code more human-readable. We can be dropping the suggestions here.

@NdibeRaymond NdibeRaymond changed the title update third-party actions for all github actions refactor github actions Dec 18, 2023
NdibeRaymond pushed a commit that referenced this issue Dec 19, 2023
refactor github actions
ade434f 
* use matrix strategy for similar jobs to save time
* update version of third-party actions
* reuse workflows

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 19, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 19, 2023
@NdibeRaymond
refactor github actions (#1036)
afa78bb 
* use matrix strategy for similar jobs to save time
* update version of third-party actions
* reuse workflows

Issue: #1030

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 20, 2023
refactor github actions
f137f1f 
* use matrix strategy for similar jobs to save time
* update version of third-party actions
* use composite actions

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 20, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 20, 2023
@NdibeRaymond
refactor github actions (#1041)
9de2230 
* use matrix strategy for similar jobs to save time
* update version of third-party actions
* use composite actions

Issue: #1030

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 20, 2023
refactor github actions
923cc70 
fix error in composite action.
for context see #1041

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 20, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 20, 2023
@NdibeRaymond
Refactor actions (#1042)
1091edf 
fix error in composite action.
for context see #1041

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 20, 2023
refactor github actions iteration=4
9af610f 
fix error in composite action.
for context see #1041

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 20, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 21, 2023
@NdibeRaymond
refactor github actions iteration=4 (#1043)
c9ed532 
fix error in composite action.
for context see #1041

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 21, 2023
refactor github actions iteration=5
5ea2ffd 
* use matrix strategy for similar jobs to save time
* update version of third-party actions
* use composite actions

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 21, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 21, 2023
@NdibeRaymond
refactor github actions iteration=5 (#1044)
f816fd8 
* use matrix strategy for similar jobs to save time
* update version of third-party actions
* use composite actions

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 21, 2023
refactor github actions iteration=6
10bbd14 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 21, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 21, 2023
@NdibeRaymond
refactor github actions iteration=6 (#1045)
70f35b5 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 21, 2023
refactor github actions iteration=7
f08124d 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 21, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 21, 2023
@NdibeRaymond
refactor github actions iteration=7 (#1046)
4cef0e2 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 21, 2023
refactor github actions iteration=8
e0f3c25 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 21, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 21, 2023
@NdibeRaymond
refactor github actions iteration=8 (#1047)
cd7f1a4 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 21, 2023
refactor github actions iteration=9
f4e9507 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 21, 2023
Merged
NdibeRaymond pushed a commit that referenced this issue Dec 21, 2023
refactor github actions iteration=9
45a4d8c 
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 22, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 22, 2023
@NdibeRaymond
refactor github actions iteration=14 (#1055)
b1d872e 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 22, 2023
refactor github actions iteration=15
7804d03 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 22, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 22, 2023
@NdibeRaymond
refactor github actions iteration=15 (#1056)
5f95580 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 22, 2023
refactor github actions iteration=16
73f8829 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 22, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 22, 2023
@NdibeRaymond
refactor github actions iteration=16 (#1057)
897d7b8 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 22, 2023
refactor github actions iteration=17
ad209be 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 22, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 22, 2023
@NdibeRaymond
refactor github actions iteration=17 (#1058)
d942226 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 22, 2023
refactor github actions iteration=18
7d0fcdd 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 22, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 22, 2023
@NdibeRaymond
refactor github actions iteration=18 (#1059)
9e0317f 
fix error in github actions.
for context see #1052

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 29, 2023
docker system prune action
3d672c3 
add action to auto perform docker system prune on all
desired vm before or after each deployment.

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 29, 2023
Merged
NdibeRaymond pushed a commit that referenced this issue Dec 29, 2023
docker system prune action
fb76d30 
add action to auto perform docker system prune on all
desired vm before or after each deployment.

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond added a commit that referenced this issue Dec 29, 2023
@NdibeRaymond
docker system prune action (#1066)
1f08bd5 
add action to auto perform docker system prune on all
desired vm before or after each deployment.

Issue: #1030

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 29, 2023
docker system prune action Iteration=2
0ca978e 
turns out you can't use values that are identical to values in the
secrets context in a way that it appears in the logs
(github doesn't allow this).
Moving all non-sensitive values from secrets to vars should fix this.

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 29, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 29, 2023
@NdibeRaymond
docker system prune action Iteration=2 (#1068)
8e2d69a 
turns out you can't use values that are identical to values in the
secrets context in a way that it appears in the logs
(github doesn't allow this).
Moving all non-sensitive values from secrets to vars should fix this.

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 29, 2023
docker system prune action Iteration=3
83c92f2 
use `docker volume rm "$volume" 2> /dev/null || true`
so an error (like volume still in use) won't cause action to exit with 1

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 29, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 29, 2023
@NdibeRaymond
docker system prune action Iteration=3 (#1069)
713af51 
use `docker volume rm "$volume" 2> /dev/null || true`
so an error (like volume still in use) won't cause action to exit with 1

Issue: #1030

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 29, 2023
remove qemu from github actions
35c4d19 
Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 29, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 29, 2023
@NdibeRaymond
remove qemu from github actions (#1070)
41ab831 
Issue: #1030

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this issue Dec 30, 2023
create_destory_test_vm minor improvement
c063811 
improve the conditions of `destroy_test_vm` to only run
when:
* pr is closed and PR still has the `create-test-vm` label
* `create-test-vm` label is removed from PR

This ensures that the `destory_test_vm` only runs when
neccessary and doesn't spam the github actions tab.

issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
@NdibeRaymond NdibeRaymond mentioned this issue Dec 30, 2023
Merged
NdibeRaymond added a commit that referenced this issue Dec 30, 2023
@NdibeRaymond
create_destory_test_vm minor improvement (#1074)
ad585bb 
* create_destory_test_vm minor improvement

use better checkmarks

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>

* create_destory_test_vm minor improvement

improve the conditions of `destroy_test_vm` to only run
when:
* pr is closed and PR still has the `create-test-vm` label
* `create-test-vm` label is removed from PR

This ensures that the `destory_test_vm` only runs when
neccessary and doesn't spam the github actions tab.

issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>

---------

Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NdibeRaymond NdibeRaymond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NdibeRaymond @yokwejuste