Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve website accessibility #912

Open
5 tasks
ghost opened this issue Apr 2, 2018 · 13 comments
Open
5 tasks

Improve website accessibility #912

ghost opened this issue Apr 2, 2018 · 13 comments
Labels
hacktoberfest Issues that need help from new contributors up-for-grabs

Comments

@ghost
Copy link

ghost commented Apr 2, 2018

I have spotted some possible improvements that would help make up-for-grabs.net more accessible to all users. Some possible changes that I suggest would be:

  • Include labels for inputs (helps with screen reader accessibility even if visibly hidden)
  • Add ARIA attributes such as "roles" and "describedby"
  • Improve keyboard navigation (I suggest that tabbing moves between project titles and skips project tags & "up-for-grabs" label)
  • Improve semantic HTML use by, for example, fixing nonconsecutive heading level use (many h1 tags) without altering visual presentation of course
  • Improve overall screen reader experience (humanise descriptions to avoid, for example, “Select a tag ellipsis edit text”)

I would be more than happy to take this on and make further improvements if you have other suggestions!

@dahlbyk
Copy link
Member

dahlbyk commented May 7, 2018

Ghost is gone, but any of these seem like good ideas. I do wonder about keyboard navigation; what if we used vim-style j/k to move up and down through the list?

@allieholcombe
Copy link

I would be interested in pursuing this a11y update.

@lbeckman314
Copy link
Contributor

I opened pull request #994 that hopefully ticks two of the above boxes.

  • Include labels for inputs (helps with screen reader accessibility even if visibly hidden)

  • Add ARIA attributes such as "roles" and "describedby"

  • Improve keyboard navigation (I suggest that tabbing moves between project titles and skips project tags & "up-for-grabs" label)

  • Improve semantic HTML use by, for example, fixing nonconsecutive heading level use (many h1 tags) without altering visual presentation of course

  • Improve overall screen reader experience (humanise descriptions to avoid, for example, “Select a tag ellipsis edit text”)

I'm still very new to github issues, so if @alexandraholcombe or @dahlbyk have advice for these and other improvements, I'd be very open to them! : )

@allieholcombe
Copy link

Update: I've been working on the semantic HTML use, ended up consulting some a11y experts at my company in regards to some options. PR is forthcoming, probably next day or two.

@catherineluse
Copy link

I can add ARIA attributes

@ritwik12
Copy link
Collaborator

@catherineluse Please go with it. Thanks for taking interest :)

@bellomuboye
Copy link

Good day, May I know the update on this issue

@catherineluse
Copy link

I should unassign myself

@ritwik12
Copy link
Collaborator

@bellomuboye you can take it up

@ghost
Copy link

ghost commented Dec 20, 2021

I could probably help with this if we still want to work on it?

@ritwik12
Copy link
Collaborator

@ConnorAhern Yep, feel free to.

@ritwik12 ritwik12 added the hacktoberfest Issues that need help from new contributors label Sep 29, 2022
@thisisamish
Copy link

Hey, can I work on this? If yes, then do I need to work on all the issues mentioned here or can I pick and choose?

@GingerKiwi
Copy link

Hi, I'm a new dev + new to open source, and . But I am a former special ed teacher/assistive tech specialist. I'd love to contribute to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues that need help from new contributors up-for-grabs
Projects
None yet
Development

No branches or pull requests

8 participants