Improve website accessibility #994
Conversation
- skips over project tags and "up-for-grabs" labels
_includes/scripts.html
Outdated
| <h5>Filter by name: </h5> | ||
| <select class="names-filter" multiple data-placeholder="Select a project..." > | ||
| <label for="project">Filter by name:</label> | ||
| <select class="names-filter" multiple data-placeholder="Select a project..." id="project"> | ||
| <% _.each(names, function(entry, key){ %> |
There was a problem hiding this comment.
Almost identical to what I had in the works, only difference being that my ids were a smidgen more descriptive (filter-by-name-input etc.)
There was a problem hiding this comment.
You probably can't go wrong being more descriptive. In that case I would elect to use your improvements over mine!
There was a problem hiding this comment.
@alexandraholcombe I think you haven't sent a PR, please send a PR.
There was a problem hiding this comment.
@ritwik12 @lbeckman314 This PR includes a few changes mine doesn't include. I'll put that in this evening, but I recommend merging this first.
|
@lbeckman314 it looks like there's some conflicts on this PR, and I'm not sure of the resolution. Are you able to take a look? |
|
Absolutely. I will take a look. |
- Include labels for inputs (helps with screen reader accessibility even if visibly hidden) - Improve keyboard navigation (I suggest that tabbing moves between project titles and skips project tags & "up-for-grabs" label)
- Include labels for inputs (helps with screen reader accessibility even if visibly hidden) - Improve keyboard navigation (I suggest that tabbing moves between project titles and skips project tags & "up-for-grabs" label)
|
Fetched changes from upstream. Resolved and ready for review. |
Ticks two of the boxes from #912
Include labels for inputs (helps with screen reader accessibility even if visibly hidden)
Improve keyboard navigation (I suggest that tabbing moves between project titles and skips project tags & "up-for-grabs" label)
I'm still very new to pull requests, so any edits or recommendations on the commits are more than welcome. : )