-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fieldPath field #120
Closed
Closed
fieldPath field #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
3 tasks
opened #121 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR buids on #119, as such the diff currently includes both.
To see only new additions, use avalanche123/xgql@no-json-if-not-requested...field-path
Description of your changes
Add a new field
fieldPath
that deprecatesunstructured
and allows to beexact in which data needs to be selected:
Some modification of gqlgen's code generation process was necessary to remove
the no longer used
Unstructured
field and enforce delegation for the "unstructured"and "fieldPath" fields to the embedded
model.PavedAccess
field of generatedstructs.
I have:
make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
I've tested it both locally via playground and on a running MCP via console.