Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbolt-cache: debug log when cleaning objects, and throttle to once per 1s #135

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

sttts
Copy link
Collaborator

@sttts sttts commented Nov 21, 2023

We are continously cleaning objects it seems. In upbound/sttts-2000-claims roughly 25-30 per second, despite no requests.

This PR makes that visible.

Test locally by running with the playground again upper controlplane.

if err := c.cleanFn(objs); err != nil {
return err
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd want to stop the process here normally.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

For context, it's printed here and the cache is removed:

	go func() {
		err := ca.Start(ctx)
		log.Debug("Cache stopped", "error", err)

		// Start blocks until ctx is closed, or it encounters an error. If we make
		// it here either the cache crashed, or the context was cancelled (e.g.
		// because our session expired).
		c.remove(id)
	}()

So, it's not the process in the unix sense that is stopped, but the cache.

…r 1s

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts sttts merged commit c373ba5 into upbound:main Nov 21, 2023
7 of 8 checks passed
@sttts sttts deleted the sttts-bbolt-cache-log branch November 21, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants