[release-0.1] Improve the heuristics we use to identify resource types #61
+207
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes GetKubernetesResource a little more robust in the face of ambiguous resources, for example an XR that has a composition selector set but that is not able to set its composition ref because no composition matches. These heuristics are still flawed; for example we would be unable to identify a pathological XR with no compositionRef, compositionSelector, or resourceRefs. Signed-off-by: Nic Cope <negz@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Backport of #60
This makes GetKubernetesResource a little more robust in the face of ambiguous resources, for example an XR that has a composition selector set but that is not able to set its composition ref because no composition matches.
These heuristics are still flawed; for example we would be unable to identify a pathological XR with no compositionRef, compositionSelector, or resourceRefs.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
See #60