Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #114

Closed
wants to merge 5 commits into from
Closed

Update package.json #114

wants to merge 5 commits into from

Conversation

hexsecs
Copy link
Member

@hexsecs hexsecs commented Oct 30, 2023

Summary of Changes

Created dependency resolutions to fix the following dependabot alerts.
https://github.com/uptane/uptane.github.io/security/dependabot/1
https://github.com/uptane/uptane.github.io/security/dependabot/2

Related Issue

Closes #113

Checklist

  • I have read and followed the project's contribution guidelines, including code style and commit message conventions.
  • My code is well-documented, and I've updated relevant documentation.
  • I have added or updated test cases to ensure the code's functionality.
  • I have tested these changes on my local environment.
  • All tests pass, and there are no new linting errors.
  • I have reviewed and proofread my code and the changes.
  • The branch is up-to-date with the base branch.

Screenshots (if applicable)

Attach any screenshots or images related to the changes.

Additional Context

Add any additional context or information that might be helpful for reviewers.

Reviewer(s)

@mention any specific reviewers or tag relevant team members.

@hexsecs
Copy link
Member Author

hexsecs commented Oct 30, 2023

@Abhijay007 @JustinCappos I created a pull request to fix those pesky dependency vulnerabilities from dependabot. Everything looks to be working fine after following the suggestion of manually updating the trim and got packages.

@Abhijay007
Copy link
Collaborator

Abhijay007 commented Oct 30, 2023 via email

@hexsecs
Copy link
Member Author

hexsecs commented Oct 30, 2023

@Abhijay007 according this this it is best practice to version your yarn.lock.

https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for

Having the traceability in the repository helps prevent 'works on my machine' bugs.

@Abhijay007
Copy link
Collaborator

Abhijay007 commented Oct 30, 2023 via email

@hexsecs
Copy link
Member Author

hexsecs commented Oct 30, 2023

Here is the docu from the official yarn site about it...

Check into source control

All yarn.lock files should be checked into source control (e.g. git or mercurial). This allows Yarn to install the same exact dependency tree across all machines, whether it be your coworker’s laptop or a CI server.

Framework and library authors should also check yarn.lock into source control. Don’t worry about publishing the yarn.lock file as it won’t have any effect on users of the library.

See https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/.

@Abhijay007
Copy link
Collaborator

Abhijay007 commented Oct 30, 2023 via email

@hexsecs hexsecs marked this pull request as draft October 30, 2023 20:02
@hexsecs hexsecs closed this Oct 31, 2023
@hexsecs hexsecs deleted the hexsecs-patch-1 branch October 31, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] - Fix security vulnerabilities flagged by dependabot
2 participants