Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alternative backend syntax example for DRink! #331

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

davidsemakula
Copy link
Contributor

@davidsemakula
Copy link
Contributor Author

@cmichi Additionally, the example link here is also broken.
It can be fixed by linking to https://github.com/paritytech/ink/blob/master/integration-tests/e2e-runtime-only-backend/lib.rs but I think the intention was to copy that test over to the ink! examples repo?

@cmichi
Copy link
Collaborator

cmichi commented Mar 11, 2024

@davidsemakula Could you check that there's nothing to be updated for either use-ink/ink#2143 nor use-ink/ink#2140?

@cmichi
Copy link
Collaborator

cmichi commented Mar 11, 2024

@cmichi Additionally, the example link here is also broken. It can be fixed by linking to https://github.com/paritytech/ink/blob/master/integration-tests/e2e-runtime-only-backend/lib.rs but I think the intention was to copy that test over to the ink! examples repo?

Thanks for flagging it! We'll copy the test over. @smiasojed Can you take care of including this test in our public examples?

The intention behind the copying was that the ink-examples contain examples with a source code that fits the last published release, whereas the contracts in ink/integration-tests often already have some breaking unreleased changes in master.

@davidsemakula
Copy link
Contributor Author

davidsemakula commented Mar 11, 2024

... Could you check that there's nothing to be updated for either paritytech/ink#2143 nor paritytech/ink#2140?

@cmichi confirmed 👍
5.x docs don't (mis)use any syntax that's been removed/changed by use-ink/ink#2140, use-ink/ink#2143 or use-ink/ink#2146

@cmichi cmichi merged commit 3065033 into use-ink:master Mar 13, 2024
4 checks passed
@davidsemakula davidsemakula deleted the v5-drink-runtime-only-syntax branch March 13, 2024 10:29
cmichi added a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants