Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewal of the top page design #1134

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

aymkx
Copy link
Contributor

@aymkx aymkx commented Aug 1, 2024

No description provided.

Copy link

github-actions bot commented Aug 1, 2024

🚀 Deployed on https://deploy-preview-1134--utelecon.netlify.app

Copy link
Member

@cm-ayf cm-ayf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSSは他の人に見てもらいたいです.

src/components/pages/Events.astro Outdated Show resolved Hide resolved
@@ -1,5 +1,5 @@
.top__systems {
column-count: 2;
// column-count: 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: merge前には消す

src/components/pages/Notice.astro Outdated Show resolved Hide resolved
src/components/pages/Events.astro Outdated Show resolved Hide resolved
src/components/pages/Events.astro Outdated Show resolved Hide resolved
}

interface Props {
show: string[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternativeを取るより、これが(string | EventInformation)[]を取るようにする方が幸せな気がします。
つまり、Astro.globからMapを作っておいて、showをmapするときにstringであればそのMapから取ってきて、EventInformationであればそのまま使うわけです。

@aymkx aymkx added the web-development Tasks of web-development category label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-development Tasks of web-development category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants