Smart Pointers support (see enhancement #194) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int remsize = delegate::call(source, [](Board &b) { return b.Size(); }); | ||
|
|
||
| /* create a new board with an extra column to place the next queen */ | ||
| Board *local = new Board(remsize+1); |
There was a problem hiding this comment.
My preference would be to have clone actually make an exact duplicate, and then have a method that would let you add a column to the end of a Board. Seems cleaner.
There was a problem hiding this comment.
For instance, insertQueen could just resize the underlying array when needed.
There was a problem hiding this comment.
Yeah! I had that at some point, but the optimiser in me took over =P
I can restore that version tho.
There was a problem hiding this comment.
Yeah, seeing as this meant to be the maximally-readable version, I'd like to keep the semantics of clone as clean as possible.
|
Two top-level things:
|
. using #pragma once . using DVLOG(2) . changed the names of methods/functions to be more Grappa-like . More readable version of nqueens-smt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic smart pointers implementation.
I also added a version of NQueens using the smart pointer support and a basic unit test (which I am not totally sure if it is done correctly).