-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Thanks for the PR! Personally I like the |
I searched your GH org for prior art https://github.com/search?q=org%3Avaadin+.editorconfig&type=Code and even though only 4 matches and nearly all the same, other than some comments, ended up picking what looked like the cleanest https://github.com/vaadin/base-starter-angular/blob/7dbd434db2c2c36807533f018c45c62f3837cf7f/.editorconfig for the base. As far as I can tell, all web components are already following this format (I admit, no detail analysis has been run), so making these conventions explicit shouldn't cause any discomfort. |
|
||
[*.md] | ||
max_line_length = off | ||
trim_trailing_whitespace = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why trailing whitespaces should be allowed in md files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a matter fact, I have no idea, was curious about this myself. But I thought since I think all GH searches through your repos had this set, maybe you guys specifically somewhat agreed on this already.
OTOH, it could also be some kind of a boilerplate default that I'm not aware of?
Google pointed me to editorconfig/editorconfig-vscode#153
When I add 2 spaces to the end of a line to create a markdown line break and then save the file, the trailing spaces are removed.
So apparently trailing whitespace logic is part of MD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, thanks @lkraav!
Editors could get the right idea from the start. Any reason why not?
This change is