Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/transform strategy #40

Merged
merged 24 commits into from
Oct 25, 2016
Merged

Conversation

vadymmarkov
Copy link
Owner

There is a list of changes that I'm planning to include in the next major release.

  1. Add Travis.
  2. Use SwiftLint to enforce Swift style and conventions.
  3. Refactor project structure and code.
  4. Remove public and open access modifiers to make public API cleaner.
  5. Breaking API change: Remove transform from Config, as @glaurent suggested. From now transformer should be specified in order to conform to Estimator protocol:
protocol Estimator {
  var transformer: Transformer { get }
  // ...
}
  1. Update README.

@vadymmarkov
Copy link
Owner Author

@glaurent I've got a chance to test demo with YIN algorithm on my acoustic guitar and it works way better than HPS 🎉

@glaurent
Copy link
Contributor

@vadymmarkov yay 👍

@vadymmarkov vadymmarkov merged commit af70b02 into master Oct 25, 2016
@vadymmarkov vadymmarkov deleted the refactor/transform-strategy branch October 25, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants