Fixed jumping items on component resize. #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itmes that are not leftmost in grid "jumped" when resizing the grid component. This was due to the 0.2s transition animation playing whenever the grid component is resized. Leftmost items transition in place thats why they appear to not jump. The fix temporarily adds a CSS class called stopMove to the item in MoveResize whenever the grid component resizes. This class overwrites the transition attribute such that no transition is played. It is added via the flag moveAnimation. MoveAnimation is set in the onResize handler for throttleUpdate + 100ms duration. +100ms is required as exact matching of the throttleUpdate duration leads to stuttering.
|
Fix for issue #125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items that are not leftmost in grid "jumped" when resizing the grid component.
This was due to the 0.2s transition animation playing whenever the grid component is resized.
Leftmost items transition in place thats why they appear to not jump.
The fix temporarily adds a CSS class called stopMove to the item in MoveResize whenever the grid component resizes.
This class overwrites the transition attribute such that no transition is played.
It is added via the flag moveAnimation.
MoveAnimation is set in the onResize handler for throttleUpdate + 100ms duration.
+100ms is required as exact matching of the throttleUpdate duration leads to stuttering.