Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Workflows: CodeQL v1 is deprecated #2149

Closed
pano9000 opened this issue Jan 17, 2023 · 1 comment · Fixed by #2150
Closed

PR Workflows: CodeQL v1 is deprecated #2149

pano9000 opened this issue Jan 17, 2023 · 1 comment · Fixed by #2150
Labels

Comments

@pano9000
Copy link
Contributor

Describe the bug
CodeQL v1 is getting deprecated
This of course affects all of the pull requests here, since those tests will fail.

Since CodeQL is switching to Node.js 16, and this project for some reason still wants to be compatible with older unsupported Node.js projects still, I have no idea, if it is just enough to switch that "v1" into a "v2" inside https://github.com/validatorjs/validator.js/blob/master/.github/workflows/codeql-analysis.yml

Just wanted to bring this to the attention of everybody here.

@WikiRik
Copy link
Member

WikiRik commented Jan 17, 2023

CodeQL runs checks that are independent of the Node version/features so yes you can just open a PR to update v1 to v2 to solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants