Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (isMobilePhone) add Cyprus validation #1897

Merged
merged 2 commits into from
Jul 19, 2022
Merged

feat: (isMobilePhone) add Cyprus validation #1897

merged 2 commits into from
Jul 19, 2022

Conversation

ikerasiotis
Copy link
Contributor

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1897 (9cfd06a) into master (f055c11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...9cfd06a. Read the comment docs.

profnandaa
profnandaa previously approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution 🎉

// And sorry for the delay in reviewing this.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 22, 2022
@profnandaa
Copy link
Member

Just fix the m/c on README and we should be good to go.

@rubiin rubiin merged commit 3873ebf into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ArthurMaverick ArthurMaverick mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
@wambugucoder wambugucoder mentioned this pull request May 30, 2024
Open
@rntvicente rntvicente mentioned this pull request May 30, 2024
Open
@DefenderK DefenderK mentioned this pull request May 30, 2024
Closed
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 30, 2024
Open
@ArthurMaverick ArthurMaverick mentioned this pull request May 31, 2024
Open
@ceconcarlsen ceconcarlsen mentioned this pull request May 31, 2024
Open
@sumandas0 sumandas0 mentioned this pull request May 31, 2024
Open
@zolamk zolamk mentioned this pull request Jun 3, 2024
Closed
This was referenced Jun 3, 2024
Closed
Closed
@DefenderK DefenderK mentioned this pull request Jun 7, 2024
Closed
@IT21275210 IT21275210 mentioned this pull request Jun 8, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 10, 2024
Closed
@florinMiro florinMiro mentioned this pull request Jun 11, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Jun 11, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jun 12, 2024
Closed
@zolamk zolamk mentioned this pull request Jun 12, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jun 12, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Jun 13, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jun 13, 2024
Closed
This was referenced Jun 14, 2024
Closed
Closed
@DefenderK DefenderK mentioned this pull request Jun 14, 2024
Closed
This was referenced Jun 18, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 28, 2024
Closed
Closed
Closed
This was referenced Jul 10, 2024
Closed
Closed
Closed
@rm-neilsondesa rm-neilsondesa mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jul 18, 2024
Closed
This was referenced Jul 19, 2024
Closed
Closed
Closed
@officialmofabs officialmofabs mentioned this pull request Aug 3, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 21, 2024
Open
@luizhp luizhp mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin approved these changes

@profnandaa profnandaa profnandaa left review comments

Assignees
No one assigned
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikerasiotis @profnandaa @rubiin