feat (isMobilePhone): add Nicaragua validator #1909

ajGingrich · 2022-01-20T14:47:51Z

Add Nicaragua to Mobile Phone validation

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-01-20T14:49:18Z

Codecov Report

Merging #1909 (23d94ae) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1909   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...23d94ae. Read the comment docs.

braaar · 2022-01-20T14:51:53Z

README.md

@@ -109,7 +109,7 @@ Validator                               | Description
 **isDecimal(str [, options])**             | check if the string represents a decimal number, such as 0.1, .3, 1.1, 1.00003, 4.0, etc.<br/><br/>`options` is an object which defaults to `{force_decimal: false, decimal_digits: '1,', locale: 'en-US'}`<br/><br/>`locale` determine the decimal separator and is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'es-ES', 'fa', 'fa-AF', 'fa-IR', 'fr-FR', 'fr-CA', 'hu-HU', 'id-ID', 'it-IT', 'ku-IQ', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pl-Pl', 'pt-BR', 'pt-PT', 'ru-RU', 'sl-SI', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'tr-TR', 'uk-UA', 'vi-VN']`.<br/>**Note:** `decimal_digits` is given as a range like '1,3', a specific value like '3' or min like '1,'.
 **isDivisibleBy(str, number)**          | check if the string is a number that's divisible by another.
 **isEAN(str)**                          | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])**            | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '', host_blacklist: [] }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` receives a string, then the validator will reject emails that include any of the characters in the string, in the name part. If `host_blacklist` is set to an array of strings and the part of the email after the `@` symbol matches one of the strings defined in it, the validation fails. 
+**isEmail(str [, options])**            | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '', host_blacklist: [] }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` receives a string, then the validator will reject emails that include any of the characters in the string, in the name part. If `host_blacklist` is set to an array of strings and the part of the email after the `@` symbol matches one of the strings defined in it, the validation fails.


Suggested change

**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '', host_blacklist: [] }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` receives a string, then the validator will reject emails that include any of the characters in the string, in the name part. If `host_blacklist` is set to an array of strings and the part of the email after the `@` symbol matches one of the strings defined in it, the validation fails.

**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '', host_blacklist: [] }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` receives a string, then the validator will reject emails that include any of the characters in the string, in the name part. If `host_blacklist` is set to an array of strings and the part of the email after the `@` symbol matches one of the strings defined in it, the validation fails.

If you could add the trailing space back in here we can avoid irrelevant changes

updated and should be good now.

rubiin

Looks good

ajGingrich · 2022-03-15T15:21:24Z

anything else need to be done to get this merged? or waiting on official approve

WikiRik · 2022-03-21T12:26:06Z

Yup, just waiting on official approval

rubiin · 2022-03-21T12:39:15Z

@profnandaa @ezkemboi few PRS are good to go , you might want to check

ezkemboi · 2022-03-21T12:40:15Z

Sure @rubiin at the course of the week.

profnandaa

LGTM, thanks for your contrib 🎉

// And sorry for the delay in reviewing this.

profnandaa · 2022-04-22T03:20:37Z

Just fix the merge conflict on README if possible, or I will fix them in a batch PR...

rubiin · 2022-07-19T17:00:42Z

Thankyou for the contribution 🎉

feat (isMobilePhone): add Nicaragua validator

7c396cc

ajGingrich mentioned this pull request Jan 20, 2022

Mobile Phone validations - For The First Time Contributors #1761

Open

braaar reviewed Jan 20, 2022

View reviewed changes

add back trailing space to readme

23d94ae

rubiin previously approved these changes Feb 14, 2022

View reviewed changes

profnandaa previously approved these changes Apr 22, 2022

View reviewed changes

profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 22, 2022

Merge branch 'master' into nicaragua-phone

f2d7e04

rubiin dismissed stale reviews from profnandaa and themself via f2d7e04 July 19, 2022 17:00

rubiin approved these changes Jul 19, 2022

View reviewed changes

rubiin merged commit edce476 into validatorjs:master Jul 19, 2022

profnandaa mentioned this pull request Feb 2, 2023

maintenance: release 2301 prep - v13.9.0 #2166

Closed

rntvicente mentioned this pull request May 24, 2024

[Snyk] Upgrade validator from 13.5.2 to 13.11.0 rntvicente/ts-clean-architecture#25

Open

sahilpawar58 mentioned this pull request May 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat (isMobilePhone): add Nicaragua validator #1909

feat (isMobilePhone): add Nicaragua validator #1909

ajGingrich commented Jan 20, 2022

codecov bot commented Jan 20, 2022 •

edited

Loading

braaar Jan 20, 2022

ajGingrich Jan 20, 2022

rubiin left a comment

ajGingrich commented Mar 15, 2022

WikiRik commented Mar 21, 2022

rubiin commented Mar 21, 2022

ezkemboi commented Mar 21, 2022

profnandaa left a comment

profnandaa commented Apr 22, 2022

rubiin commented Jul 19, 2022

feat (isMobilePhone): add Nicaragua validator #1909

feat (isMobilePhone): add Nicaragua validator #1909

Conversation

ajGingrich commented Jan 20, 2022

Checklist

codecov bot commented Jan 20, 2022 • edited Loading

Codecov Report

braaar Jan 20, 2022

Choose a reason for hiding this comment

ajGingrich Jan 20, 2022

Choose a reason for hiding this comment

rubiin left a comment

Choose a reason for hiding this comment

ajGingrich commented Mar 15, 2022

WikiRik commented Mar 21, 2022

rubiin commented Mar 21, 2022

ezkemboi commented Mar 21, 2022

profnandaa left a comment

Choose a reason for hiding this comment

profnandaa commented Apr 22, 2022

rubiin commented Jul 19, 2022

codecov bot commented Jan 20, 2022 •

edited

Loading