Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isLicensePlate): remove duplicate char from character class #2085

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

pedroprado010
Copy link
Contributor

@pedroprado010 pedroprado010 commented Oct 23, 2022

The str validator had the 'K' char two times in its regexp character class. This PR removes one of them.

ABCDEFHKIJKLMNPRSTUVXYZ -> ABCDEFHIJKLMNPRSTUVXYZ

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3769e30) compared to base (531dc7f).
Patch has no changes to coverable lines.

❗ Current head 3769e30 differs from pull request most recent head b97bb89. Consider uploading reports for the commit b97bb89 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2085   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           
Impacted Files Coverage Δ
src/lib/isLicensePlate.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the other K for alphabetical order?

@pedroprado010
Copy link
Contributor Author

Sure thing @WikiRik!

can you please add the hacktober tag after merge?

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer of this repo so I can't add the label but I think the maintainers will keep this in mind for you

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, good catch!

@profnandaa profnandaa merged commit 8deae54 into validatorjs:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants