Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(isVAT): Corrected validation for Swiss (CH) vat-number #2203

Merged
merged 5 commits into from
Mar 27, 2023
Merged

fix(isVAT): Corrected validation for Swiss (CH) vat-number #2203

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85730bf
correct isVAT regex for CH
jimmyorpheus Mar 17, 2023
72c3ac7
use checkdigit for swiss isvat
jimmyorpheus Mar 18, 2023
152f4f6
allow space as number separator, edit test cases
jimmyorpheus Mar 19, 2023
c3a4336
fix: correct test-case, edit comment
jimmyorpheus Mar 19, 2023
823323e
extract vat matcher for Switzerland (CH)
jimmyorpheus Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/lib/isVAT.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,20 @@ export const vatMatchers = {
SM: str => /^(SM)?\d{5}$/.test(str),
SA: str => /^(SA)?\d{15}$/.test(str),
RS: str => /^(RS)?\d{9}$/.test(str),
CH: str => /^(CH)?(\d{6}|\d{9}|(\d{3}.\d{3})|(\d{3}.\d{3}.\d{3}))(TVA|MWST|IVA)$/.test(str),
CH: (str) => {
jimmyorpheus marked this conversation as resolved.
Show resolved Hide resolved
// @see {@link https://www.ech.ch/de/ech/ech-0097/5.2.0}
const hasValidCheckNumber = (digits) => {
const lastDigit = digits.pop(); // used as check number
const weights = [5, 4, 3, 2, 7, 6, 5, 4];
const calculatedCheckNumber = (11 - (digits.reduce((acc, el, idx) =>
acc + (el * weights[idx]), 0) % 11)) % 11;

return lastDigit === calculatedCheckNumber;
};

// @see {@link https://www.estv.admin.ch/estv/de/home/mehrwertsteuer/uid/mwst-uid-nummer.html}
return /^(CHE[- ]?)?(\d{9}|(\d{3}[\. ]\d{3}[\. ]\d{3})) ?(TVA|MWST|IVA)?$/.test(str) && hasValidCheckNumber((str.match(/\d/g).map(el => +el)));
},
TR: str => /^(TR)?\d{10}$/.test(str),
UA: str => /^(UA)?\d{12}$/.test(str),
GB: str => /^GB((\d{3} \d{4} ([0-8][0-9]|9[0-6]))|(\d{9} \d{3})|(((GD[0-4])|(HA[5-9]))[0-9]{2}))$/.test(str),
Expand Down
36 changes: 24 additions & 12 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13865,18 +13865,30 @@ describe('Validators', () => {
validator: 'isVAT',
args: ['CH'],
valid: [
'CH123456TVA',
'123456TVA',
'CH123456789MWST',
'123456789MWST',
'CH123.456IVA',
'123.456IVA',
'CH123.456.789TVA',
'123.456.789TVA',
],
invalid: [
'CH 123456',
'12345',
// strictly valid
jimmyorpheus marked this conversation as resolved.
Show resolved Hide resolved
'CHE-116.281.710 MWST',
'CHE-116.281.710 IVA',
'CHE-116.281.710 TVA',
// loosely valid presentation variants
'CHE 116 281 710 IVA', // all separators are spaces
'CHE-191.398.369MWST', // no space before suffix
'CHE-116281710 MWST', // no number separators
'CHE-116281710MWST', // no number separators and no space before suffix
'CHE105854263MWST', // no separators
'CHE-116.285.524', // no suffix (vat abbreviation)
'CHE116281710', // no suffix and separators
'116.281.710 TVA', // no prefix (CHE, ISO-3166-1 Alpha-3)
'116281710MWST', // no prefix and separators
'100.218.485', // no prefix and suffix
'123456788', // no prefix, separators and suffix
],
invalid: [
'CH-116.281.710 MWST', // invalid prefix (should be CHE)
'CHE-116.281 MWST', // invalid number of digits (should be 9)
'CHE-123.456.789 MWST', // invalid last digits (should match the calculated check-number 8)
'CHE-123.356.780 MWST', // invalid check-number (there are no swiss UIDs for the calculated check number 10)
'CH-116.281.710 VAT', // invalid suffix (should be MWST, IVA or TVA)
'CHE-116/281/710 IVA', // invalid number separator (should be dot or space or empty-string)
],
});
test({
Expand Down