Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IsFQDN): Add a test that asserts numeric chars in tld are rejected by default. #2222

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

aalekhpatel07
Copy link
Contributor

feat(isFQDN): Add a test that asserts numeric chars in tlds are rejected by default.

Add a test that cements the default behaviour of isFQDN of rejecting tld with numeric data, and also that valiation can be relaxed by passing {allow_numeric_tld: true}

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Signed-off-by: Aalekh Patel <aalekh@protectchildren.ca>
Signed-off-by: Aalekh Patel <aalekh@protectchildren.ca>
@aalekhpatel07 aalekhpatel07 changed the title Add a test that asserts numeric chars in tld are rejected by default. feat(IsFQDN): Add a test that asserts numeric chars in tld are rejected by default. May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ba1735) 99.95% compared to head (a73ed46) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2222   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2405     2405           
  Branches      604      604           
=======================================
  Hits         2404     2404           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we are not testing for solely allow_numeric_tld: true so this looks good to me. We'll move the other tests for isFQDN to this file later

@profnandaa
Copy link
Member

Thanks for the PR!

@profnandaa profnandaa merged commit ad41eba into validatorjs:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants