Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isAlpha, isAlphanumeric): add kazakh locale, kk-KZ #2226

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

BekStar7
Copy link
Contributor

Hello!
I added Kazakh locale(kk-KZ) to isAlpha/isAlphanumeric.

Thanks in advance.

https://en.wikipedia.org/wiki/Kazakh_alphabets

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ba1735) 99.95% compared to head (0558566) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2226   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2405     2405           
  Branches      604      604           
=======================================
  Hits         2404     2404           
  Partials        1        1           
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wikipedia mentions that multiple alphabets is used in Kazakhstan. Do you have some additional sources that show that this is the best approach?

@BekStar7
Copy link
Contributor Author

BekStar7 commented May 25, 2023

Wikipedia mentions that multiple alphabets is used in Kazakhstan. Do you have some additional sources that show that this is the best approach?

At the moment, the Latin script has not yet been approved at the legislative level, it is under consideration. Most sites and applications are in Cyrillic.
https://egov.kz/cms/en/articles/culture/Alfavit-kazahskogo-yazyka-na-latinice
In Kazakhstan used Cyrillic:
https://www.ethnologue.com/language/kaz/

@BekStar7 BekStar7 requested a review from WikiRik May 29, 2023 04:28
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contrib! 🎉

@profnandaa profnandaa merged commit 4f63909 into validatorjs:master Jun 12, 2023
@nurbek0298
Copy link

Hello @profnandaa!
I would like to request you to release the branch on npm. It includes significant updates that have been made to the project. It would be greatly appreciated if you could proceed with the release as soon as possible. Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants