Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature branch #2292

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature branch #2292

wants to merge 4 commits into from

Conversation

Manu024
Copy link

@Manu024 Manu024 commented Sep 28, 2023

feat(isMobilePhone): Added regex for Puerto Rico 'es-PR'

Added mobile number validation 'es-PR'

Update README.md with 'es-PR'

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@gauravnewton
Copy link

Test failing

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add sources

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (3f70cb8) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2292      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              
Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manu024
Copy link
Author

Manu024 commented Oct 1, 2023

Fix some typos with new commit, commit id - 3f70cb8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants