Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: parameterise app name used in auth #6078

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

kathaypacific
Copy link
Collaborator

Description

This PR updates the network config file to use the APP_REGISTRY_NAME env variable for the auth headers in networkConfig.ts, to reduce the number of places we need to update the app name.

Test plan

n/a

Related issues

n/a

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (f35b078) to head (d55414c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6078      +/-   ##
==========================================
- Coverage   88.73%   88.73%   -0.01%     
==========================================
  Files         727      727              
  Lines       30772    30772              
  Branches     5614     5306     -308     
==========================================
- Hits        27307    27306       -1     
- Misses       3267     3423     +156     
+ Partials      198       43     -155     
Files with missing lines Coverage Δ
src/config.ts 96.36% <100.00%> (+0.03%) ⬆️
src/web3/networkConfig.ts 100.00% <100.00%> (ø)

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35b078...d55414c. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kathaypacific kathaypacific added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 18a04af Sep 23, 2024
15 checks passed
@kathaypacific kathaypacific deleted the kathy/network-config-param branch September 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants