Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pmp): scope of the libs within repository domain #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Damian070
Copy link
Contributor

refs #141
closes #141

nx.json Outdated
},
"server-repository-core-application-services": {
"tags": ["platform:server", "scope:repository", "type:application-services"]
"tags": ["platform:server", "scope:repository-core", "type:application-services"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave server as it was

nx.json Outdated
@@ -190,15 +190,6 @@
},
"server-shared-util-typescript": {
"tags": ["platform:server", "scope:shared", "type:util"]
},
"server-shared-config": {
"tags": ["platform:server", "scope:shared", "type:config"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

@@ -10,7 +10,7 @@ function initPmpWebEnvironment(): void {
const prodEnvironmentFile = 'libs/pmp-web/shared/config/src/lib/environment/environment.prod.ts';

fs.copyFileSync(
'libs/pmp-web/shared/config/src/lib/environment/environment.sample.ts',
'libs/pmp-web/shared/config/src/lib/environment/environment.ts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@@ -1,5 +0,0 @@
export const environment = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@Damian070 Damian070 force-pushed the refactor/pmp-141 branch 6 times, most recently from e75e410 to 0597955 Compare April 24, 2020 09:27
@Damian070 Damian070 force-pushed the refactor/pmp-141 branch 3 times, most recently from a90dd2d to 1880184 Compare April 24, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope of the libs within repository domain
2 participants