Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly support java-gradle-plugin projects #115

Merged
merged 3 commits into from
Feb 14, 2020
Merged

directly support java-gradle-plugin projects #115

merged 3 commits into from
Feb 14, 2020

Conversation

gabrielittner
Copy link
Collaborator

Addresses issues mentioned in #82. Like Kotlin mpp the java-gradle-plugin creates it's own publications. We need to configure those instead of creating our own.

Also closes #111

@gabrielittner
Copy link
Collaborator Author

@ZacSweers this should fix your issues

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #115 into master will decrease coverage by 0.89%.
The diff coverage is 13.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #115     +/-   ##
===========================================
- Coverage     35.29%   34.39%   -0.9%     
- Complexity       49       51      +2     
===========================================
  Files            21       21             
  Lines           425      439     +14     
  Branches         70       73      +3     
===========================================
+ Hits            150      151      +1     
- Misses          246      258     +12     
- Partials         29       30      +1
Impacted Files Coverage Δ Complexity Δ
...nniktech/maven/publish/UploadArchivesConfigurer.kt 82.85% <0%> (-2.44%) 10 <0> (ø)
...vanniktech/maven/publish/MavenPublishConfigurer.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...vanniktech/maven/publish/BaseMavenPublishPlugin.kt 60.86% <50%> (-1.93%) 7 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16a6c3...59467f5. Read the comment docs.

@gabrielittner gabrielittner merged commit b77782a into vanniktech:master Feb 14, 2020
@gabrielittner gabrielittner deleted the java-gradle-plugin branch February 14, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test for publishing gradle plugin marker
2 participants