replace dep with go modules #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazypower
approved these changes
Sep 11, 2019
| @@ -5,7 +5,6 @@ pipeline { | |||
| agent any | |||
|
|
|||
| environment { | |||
| PROJ_PATH = '/go/src/github.com/vapor-ware/sandbox-plugin' | |||
| IMAGE_NAME = 'vaporio/sandbox-plugin' | |||
| GOVERSION = '1.12' | |||
There was a problem hiding this comment.
Did you want to clean up the GOVERSION env var here as well since its embedded in the builder image?
There was a problem hiding this comment.
yup - I was planning on doing this in the follow up "update CI to latest and greatest" PR. Wanted to keep the work for transitioning to go modules separate from greater CI updates.
| @@ -12,7 +12,7 @@ GIT_TAG ?= $(shell git describe --tags 2> /dev/null || true) | |||
| BUILD_DATE := $(shell date -u +%Y-%m-%dT%T 2> /dev/null) | |||
| GO_VERSION := $(shell go version | awk '{ print $$3 }') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
depwith go modules for project dependency managementA future PR will update the Jenkins pipeline.