Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to CI #6

Merged
merged 1 commit into from
Sep 12, 2019
Merged

updates to CI #6

merged 1 commit into from
Sep 12, 2019

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • updates CI to use the latest patterns

I added the linting and snapshot build to a parallel block, but it doesn't look like they executed in parallel -- @lazypower I'm unsure if I just declared it incorrectly, or if its not possible to do w/ the new setup.

I also noticed that it spins up a new pod for stages which will be skipped, so skipped stages have to wait until the pod is ready in order to be skipped. Not sure if there is something I should be doing in config to avoid this, or if this is a known thing and is on the plate of future improvements

Copy link
Contributor

@lazypower lazypower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of hopping across the agents. I dont think you actually need to use golang-next if you're using golang-alpha but this is also 💯 valid. Just not something I'd have thought to do because thsi will introduce a bit of a lag when building as the jobs migrate between hosts.

@edaniszewski
Copy link
Contributor Author

@lazypower made some updates to run it all on golang-alpha and to run some steps in parallel - could you give it another quick look-over?

@edaniszewski edaniszewski merged commit ff4ea68 into v3/staging Sep 12, 2019
@edaniszewski edaniszewski deleted the v3/ci branch September 12, 2019 16:25
edaniszewski added a commit that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants