Fix totally unnecessary preconditionFailure in PSQLEventsHandler (#…

…481)
vapor · Jun 13, 2024 · 5c26876 · 5c26876
1 parent ee669e9
commit 5c26876
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/Sources/PostgresNIO/New/PSQLEventsHandler.swift b/Sources/PostgresNIO/New/PSQLEventsHandler.swift
@@ -68,10 +68,8 @@ final class PSQLEventsHandler: ChannelInboundHandler {
             case .authenticated:
                 break
             }
-        case TLSUserEvent.shutdownCompleted:
-            break
         default:
-            preconditionFailure()
+            context.fireUserInboundEventTriggered(event)
         }
     }
 

diff --git a/Tests/PostgresNIOTests/New/PostgresConnectionTests.swift b/Tests/PostgresNIOTests/New/PostgresConnectionTests.swift
@@ -416,6 +416,15 @@ class PostgresConnectionTests: XCTestCase {
         }
     }
 
+    func testWeDontCrashOnUnexpectedChannelEvents() async throws {
+        let (connection, channel) = try await self.makeTestConnectionWithAsyncTestingChannel()
+
+        enum MyEvent {
+            case pleaseDontCrash
+        }
+        channel.pipeline.fireUserInboundEventTriggered(MyEvent.pleaseDontCrash)
+    }
+
     func testSerialExecutionOfSamePreparedStatement() async throws {
         let (connection, channel) = try await self.makeTestConnectionWithAsyncTestingChannel()