Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider adding a ByteToMessageDecoderVerifier test #41

Closed
weissi opened this issue Jul 13, 2019 · 0 comments · Fixed by #68
Closed

consider adding a ByteToMessageDecoderVerifier test #41

weissi opened this issue Jul 13, 2019 · 0 comments · Fixed by #68
Labels
enhancement New feature or request

Comments

@weissi
Copy link
Contributor

weissi commented Jul 13, 2019

saw that PostgresMessageDecoder is a ByteToMessageDecoder. It would be pretty cool to add a test case that leverages ByteToMessageDecoderVerifier. That gives you quite good test coverage of annoying-to-write edge cases for free. If anybody's interested and needs some guidance/example, feel free to reach out to @weissi (jw on Discord)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add byte to message verifier test vapor/postgres-nio
2 participants
@weissi @tanner0101