Use sync pipeline operations to add NIOSSLClientHandler #152
Conversation
fabianfett
force-pushed
the
ff-use-sync-pipeline-operations
branch
from
43b6b35
to
0e0caf4
Compare
|
@0xTim Agree there are no api changes in Postgres, but we bump or dependencies, that we in part reexport (like NIO) in a minor way. Therefor this needs IMO a minor release. |
|
Oh FFS why is PostgresNIO exporting everything! * sigh * you're right I'll change it back. I can't wait to get rid of all these exports! |
|
We'll it's not so much export everything. But in this case EventLoopFuture is enough. 😎 |
| @@ -215,17 +215,16 @@ final class PSQLConnection { | |||
| .channelInitializer { channel in | |||
| let decoder = ByteToMessageHandler(PSQLBackendMessage.Decoder()) | |||
|
|
|||
| var enableSSLCallback: ((Channel) -> EventLoopFuture<Void>)? = nil | |||
| var enableSSLCallback: ((Channel) throws -> ())? = nil | |||
There was a problem hiding this comment.
Super nit but this might be clearer as configureSSLCallback
| }.flatMap { sslHandler in | ||
| channel.pipeline.addHandler(sslHandler, position: .before(decoder)) | ||
| } | ||
| channel.eventLoop.preconditionInEventLoop() |
There was a problem hiding this comment.
FWIW the sync operations will do this check for you; keeping this (and potentially degrading it to an assertion) is a useful as an indicator to whoever looks at this code though.
fabianfett
force-pushed
the
ff-use-sync-pipeline-operations
branch
from
0e0caf4
to
707b9e7
Compare
|
Renamed |
PSQLChannelHandler'senableSSLCallbackto a synchronous APIchannel.pipeline.syncOperationsto add theNIOSSLClientHandlerafter it was verified that SSL is supported on this connectiontestEstablishSSLCallbackIsCalledIfSSLIsSupportedto ensure startup is send after SSL connection is established.