Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PostgresCastingError #221

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

fabianfett
Copy link
Collaborator

I forgot to add some important metadata to the PostgresCastingError. For this reason here it is... Also added some API comments that will come in handy once we make this type public.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #221 (e6b90cc) into main (112a5e5) will increase coverage by 4.85%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   42.96%   47.81%   +4.85%     
==========================================
  Files         119      119              
  Lines        8219     8217       -2     
==========================================
+ Hits         3531     3929     +398     
+ Misses       4688     4288     -400     
Flag Coverage Δ
unittests 47.81% <42.85%> (+4.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/New/PSQLError.swift 70.96% <42.85%> (+13.22%) ⬆️
...urces/PostgresNIO/New/Data/Array+PSQLCodable.swift 94.68% <0.00%> (+1.06%) ⬆️
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <0.00%> (+1.42%) ⬆️
Sources/PostgresNIO/New/PSQLConnection.swift 31.68% <0.00%> (+1.98%) ⬆️
...s/PostgresNIO/Message/PostgresMessageDecoder.swift 95.45% <0.00%> (+2.27%) ⬆️
...es/PostgresNIO/New/PSQLBackendMessageDecoder.swift 93.28% <0.00%> (+2.98%) ⬆️
...urces/PostgresNIO/New/Messages/ErrorResponse.swift 32.30% <0.00%> (+3.07%) ⬆️
...urces/PostgresNIO/New/Data/Float+PSQLCodable.swift 76.66% <0.00%> (+3.33%) ⬆️
Sources/PostgresNIO/New/PSQLBackendMessage.swift 96.63% <0.00%> (+3.36%) ⬆️
...ources/PostgresNIO/Data/PostgresData+Numeric.swift 70.44% <0.00%> (+3.64%) ⬆️
... and 19 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ❤️

@fabianfett fabianfett merged commit 4937286 into vapor:main Feb 18, 2022
@fabianfett fabianfett deleted the ff-fix-PostgresCastingError branch February 18, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants