Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PSQLCodable to PostgresCodable #225

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

fabianfett
Copy link
Collaborator

Motivation

Same as #224.

Modifications

  • Rename PSQLCodable to PostgresCodable
  • Rename PSQLEncodable to PostgresEncodable

Result

More consistent future API

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #225 (02dd8b2) into main (77eb6c7) will increase coverage by 4.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   39.10%   43.19%   +4.08%     
==========================================
  Files         121      121              
  Lines        9315     9322       +7     
==========================================
+ Hits         3643     4027     +384     
+ Misses       5672     5295     -377     
Flag Coverage Δ
unittests 43.19% <100.00%> (+4.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 94.68% <ø> (ø)
...es/PostgresNIO/New/Data/Bool+PostgresCodable.swift 95.34% <ø> (ø)
...s/PostgresNIO/New/Data/Bytes+PostgresCodable.swift 73.52% <ø> (ø)
...es/PostgresNIO/New/Data/Date+PostgresCodable.swift 89.28% <ø> (ø)
...PostgresNIO/New/Data/Decimal+PostgresCodable.swift 74.19% <ø> (ø)
...s/PostgresNIO/New/Data/Float+PostgresCodable.swift 76.66% <ø> (ø)
...ces/PostgresNIO/New/Data/Int+PostgresCodable.swift 30.71% <ø> (ø)
...es/PostgresNIO/New/Data/JSON+PostgresCodable.swift 100.00% <ø> (ø)
...ostgresNIO/New/Data/Optional+PostgresCodable.swift 83.33% <ø> (ø)
...IO/New/Data/RawRepresentable+PostgresCodable.swift 82.35% <ø> (ø)
... and 35 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh Fabian, how can you keep making such complicated changes all the time? 🤣

But I still love the cleanup ❤️ Approved!

@fabianfett fabianfett merged commit 3d5d25f into vapor:main Feb 21, 2022
@fabianfett fabianfett deleted the ff-rename-PSQLCodable branch March 13, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants