Cleanup encoding and decoding #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/PostgresNIO/Connection/PostgresConnection+Database.swift # Sources/PostgresNIO/New/Data/Optional+PostgresCodable.swift # Sources/PostgresNIO/New/PostgresCodable.swift # Sources/PostgresNIO/New/PostgresQuery.swift # Sources/PostgresNIO/Postgres+PSQLCompat.swift # Tests/PostgresNIOTests/New/Data/Optional+PSQLCodableTests.swift
fabianfett
force-pushed
the
ff-cleanup-encoding-and-decoding
branch
from
04501db
to
8084984
Compare
gwynne
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simple code is better.
We have an escape hatch to implement the encoding of optionals on PostgresEncodable. However with the introduction of
PostgresBindings, we can deal with this special case directly. Sadly this is not possible for Decoding. However we can improve the usability of the PostgresDecodable protocol, by prefixing the special values with an underscore.Changes
decodeRawonPostgresDecodableto_decodeRawDecodableTypeonPostgresDecodableto_DecodableTypePostgresEncodableResult
Less and easier code.